jewel: osd: also check the exsistence of clone obc for "CEPH_SNAPDIR" requests #17707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuehan Xu <xuxuehan@360.cn> (cherry picked from commit 5531b6b)
If the incoming request's snapid is CEPH_SNAPDIR and the object context of clones of its targeting object doesn't exist, also promote those clones This cannot be cherry-picked from master because ReplicatedPG::do_op() in "master" branch has been completely reconstructed. Fixes: http://tracker.ceph.com/issues/17445 Signed-off-by: Xuehan Xu <xuxuehan@360.cn>
liewegas
changed the title
liu-chunmei
reviewed
Sep 13, 2017
| @@ -2054,7 +2054,7 @@ void ReplicatedPG::do_op(OpRequestRef& op) | |||
| } | |||
|
|
|||
| ObjectContextRef sobc = get_object_context(clone_oid, false); | |||
| if (!sobc) { | |||
| if (!sobc || !sobc->obs.exists) { | |||
There was a problem hiding this comment.
in what operation sobc exists, but sobc->obs.exists is false?
There was a problem hiding this comment.
This happens after a clone object evicted from the cache tier
tchaikov
pushed a commit
to tchaikov/ceph
that referenced
this pull request
Nov 3, 2017
…of clone obc for "CEPH_SNAPDIR" requests Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
Um, hi, can anyone review this PR, please:-) |
|
The number of failures on kefu's earlier run make me nervous, I think this needs a pass through testing. |
|
@liewegas The baseline rados suite (on current "jewel" branch) has lots of failures in it. I'm not sure what to do about that. Yes, this is a plea for help. |
|
@smithfarm I'm working on it:-) |
|
This PR passed a rados integration run at http://tracker.ceph.com/issues/21742#note-14 with two bugs reproducing: @xxhdx1985126 @liu-chunmei @jdurgin @tchaikov Do you think it's ready to merge? |
jdurgin
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17445