pybind/rados: add support open_ioctx2 API #17710
Conversation
|
jenkins retest this please. |
|
@jdurgin Would you please help to take a look? Thanks in advance. |
doc/rbd/api/librbdpy.rst
Outdated
| @@ -17,6 +17,7 @@ context:: | |||
| cluster.connect() | |||
| ioctx = cluster.open_ioctx('mypool') | |||
|
|
|||
| Also, you can use `open_ioctx2(mypool_id)` method to open an IO. | |||
There was a problem hiding this comment.
no need to put this line in the example. it is not supposed to be exhaustive.
|
would be better to accompany this change with a test in |
Songweibin
force-pushed
the
wip-add-pybind
branch
from
e54963f
to
17003d6
Compare
|
@tchaikov Done, added a full test just like |
| @@ -891,6 +891,627 @@ def test_applications(self): | |||
| self.ioctx.application_metadata_remove("app1", "key1") | |||
| eq([("key2", "val2")], self.ioctx.application_metadata_list("app1")) | |||
|
|
|||
|
|
|||
| class TestIoctx2(object): | |||
There was a problem hiding this comment.
i don't think we need to duplicate the whole TestIoctx just for testing rados.open_ioctx2.
There was a problem hiding this comment.
yeah! i do not want to take a whole test at the beginning, but i have no idea which ones should be testing, so...your suggestions is appreciate. thanks.
Songweibin
force-pushed
the
wip-add-pybind
branch
from
17003d6
to
2897ad4
Compare
|
@tchaikov only take a simple test, would you please help to have a look again? thanks. |
Signed-off-by: songweibin <song.weibin@zte.com.cn>
Can use
client.open_ioct2(pool_id)to open an IO.Signed-off-by: songweibin song.weibin@zte.com.cn