-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osd: update dmclock library w git subtree pull #17737
Conversation
a9e777f08f Merge pull request ceph#35 from joscollin/wip-warning-dmclock 45c63a5b10 Merge pull request ceph#36 from ceph/wip-fix-functional 40a9fe55a6 With upgrade to gcc 7.1.1 need to include <functional> in additional header files. a2dd155f08 src/dmclock_server.h: silence warning from -Wmaybe-uninitialized 0d6c7c6544 Merge pull request ceph#24 from bspark8/wip_online_client_info_f a5e8cdea31 Add unit test for update_client_info, dynamic_cli_info_f. 1faf3524c6 Modify each client's QoS parameter applied time from client_rec creation time to each request's tagging creation time. git-subtree-dir: src/dmclock git-subtree-split: a9e777f08f288fe6834599afdeefcd9c7d31e6c1
…-updated-dmclock Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
Jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of your commits are not signed Signed-off-by:
.
@joscollin Yeah, when you do a |
@ivancich Do you mean you cannot |
@ivancich See this attempt https://github.com/ceph/ceph/pull/17716/commits |
@joscollin It's the first of two commits that Can you outline the commands/process you're suggesting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd suggest merge as it is.
@ivancich I was suggesting |
@ivancich for some reason, the title of this PR has |
DNM removed. In the past these have been merge-able. I'm guessing @liewegas can do it. |
The dmclock library has had a number of updates, some allowing all components to be compiled with gcc 7.1.1. We should pull it in.