doc: Fix typos in placement-groups.rst #17973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscollin
changed the title
joscollin
requested changes
Sep 27, 2017
There was a problem hiding this comment.
Aah! Your commit is not signed.
Please see: https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#1-sign-your-work.
Please do the following:
$ git commit --amend
$ Add a `Signed-off-by:` line
$ git push origin patch-1 -f
Next time use -s option in git commit to sign off automatically.
|
sorry, my fault for not checking the contribution policy. by way of apology, i found a couple more :-) (let me know if you'd rather i squashed the two commits.) |
joscollin
requested changes
Sep 27, 2017
Signed-off-by: Matt Boyle <matt.boyle@gmail.com>
joscollin
approved these changes
Sep 28, 2017
|
thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.