Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: unify {create_and_,}open() methods #18177

Merged
merged 1 commit into from Oct 10, 2017
Merged

kv: unify {create_and_,}open() methods #18177

merged 1 commit into from Oct 10, 2017

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Oct 9, 2017

this silences the warning of "-Woverloaded-virtual" where create() and
create_and_open() from KeyValueDB are hidden from the ones defined in
derived classes.

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested a review from liewegas October 9, 2017 08:56
@liewegas
Copy link
Member

liewegas commented Oct 9, 2017

build errors in the test code

@tchaikov
kv: unify {create_and_,}open() methods
385786b 
this silences the warning of "-Woverloaded-virtual" where create() and
create_and_open() from KeyValueDB are hidden from the ones defined in
derived classes.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Oct 9, 2017

@liewegas fixed and repushed

@tchaikov
Copy link
Contributor Author

@tchaikov tchaikov merged commit a753282 into ceph:master Oct 10, 2017
@tchaikov tchaikov deleted the wip-kv-kill-warning branch October 10, 2017 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

Assignees
No one assigned
Labels
cleanup needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
2 participants
@tchaikov @liewegas