vstart.sh: quote command only when necessary #18181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we quote the command args, so it's easier to copy and paste it to rerun the command. but it's annoying to read the echod command with the quotes. so quote them only if the arg has space in it, it'd easier for eyes. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-vstart-quoted-print
branch
from
5c9c0a4
to
169e159
Compare
tchaikov
changed the title
jdurgin
approved these changes
Oct 24, 2017
batrick
reviewed
Oct 25, 2017
| prunb() { | ||
| printf "'%s' " "$@"; echo '&' | ||
| quoted_print $* '&' |
There was a problem hiding this comment.
This should be quoted_print "$@" '&'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we quote the command args, so it's easier to copy and paste it to rerun
the command. but it's annoying to read the echod command with the
quotes. so quote them only if the arg has space in it, it'd easier for
eyes.
Signed-off-by: Kefu Chai kchai@redhat.com