Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vstart.sh: quote command only when necessary #18181

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Copy link
Contributor

commented Oct 9, 2017

we quote the command args, so it's easier to copy and paste it to rerun
the command. but it's annoying to read the echod command with the
quotes. so quote them only if the arg has space in it, it'd easier for
eyes.

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov added the cleanup label Oct 9, 2017

vstart.sh: quote command only when necessary
we quote the command args, so it's easier to copy and paste it to rerun
the command. but it's annoying to read the echod command with the
quotes. so quote them only if the arg has space in it, it'd easier for
eyes.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov force-pushed the tchaikov:wip-vstart-quoted-print branch from 5c9c0a4 to 169e159 Oct 9, 2017

@tchaikov tchaikov changed the title vstart.sh quote command only when necessary vstart.sh: quote command only when necessary Oct 9, 2017

@tchaikov tchaikov requested a review from jdurgin Oct 18, 2017

@jdurgin jdurgin merged commit df7a694 into ceph:master Oct 24, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
prunb() {
printf "'%s' " "$@"; echo '&'
quoted_print $* '&'

This comment has been minimized.

Copy link
@batrick

batrick Oct 25, 2017

Member

This should be quoted_print "$@" '&'?

This comment has been minimized.

Copy link
@tchaikov

tchaikov Oct 25, 2017

Author Contributor

@batrick thanks for pointing this out, fixed at #18523

@tchaikov tchaikov deleted the tchaikov:wip-vstart-quoted-print branch Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.