test: fix misc fiemap testing #18240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Different filesystem will have different behavior to allocate extents. Therefore, even if write 4000 extents, the filesystem may not really allocate 4000 extents. 2) kstore always return [0, xxx] even if offset ~= 0. Therefore, the whole non-zero offset FiemapHoles test should be skipped 3) enable fiemap test for filestore, bluestore, memstore again Fixes: http://tracker.ceph.com/issues/21716 Signed-off-by: Ning Yao <yaoning@unitedstack.com> Signed-off-by: Kefu Chai <kchai@redhat.com>
|
lgtm |
|
@jdurgin mind taking a quick review? |
jdurgin
approved these changes
Oct 13, 2017
|
this causes a regression.. see #18452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different filesystem will have different behavior to
allocate extents. Therefore, even if write 4000 extents,
the filesystem may not really allocate 4000 extents.
kstore always return [0, xxx] even if offset ~= 0. Therefore,
the whole non-zero offset FiemapHoles test should be skipped
enable fiemap test for filestore, bluestore, memstore again
Fixes: http://tracker.ceph.com/issues/21716
Signed-off-by: Ning Yao yaoning@unitedstack.com
Signed-off-by: Kefu Chai kchai@redhat.com