mgr: In plugins 'module' classes need not to be called "Module" anymore. #18526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-17454
branch
2 times, most recently
from
c3b023f
to
c4d900e
Compare
|
the failures are addressed by #18533 |
|
need to rebase after 213cbd6 is merged |
tchaikov
force-pushed
the
wip-17454
branch
4 times, most recently
from
6df4742
to
2a063a8
Compare
|
@jcsp mind taking a look? |
|
Looks good, let's also update the docs in this PR, in plugins.rst where it says "create a class |
|
Let's run the rados/mgr suite on this before merging, as it has several new tests since 213cbd6 merged |
Fixes: http://tracker.ceph.com/issues/17454 Signed-off-by: Kefu Chai <kchai@redhat.com> Signed-off-by: bhavishyagopesh <bhavishyagopesh@gmail.com>
|
@jcsp the tests failed: http://pulpito.ceph.com/kchai-2017-11-02_08:11:58-rados-wip-17454-kefu-distro-basic-mira/ but the master branch also failed http://pulpito.ceph.com/kchai-2017-11-02_09:53:26-rados-master-distro-basic-mira/ strange enough, when i enable the "selftest" module in my testbed, the ceph-mgr does respawn itself and "active_gid" changes. |
|
hmm, passed for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/17454
Signed-off-by: bhavishyagopesh bhavishyagopesh@gmail.com
Signed-off-by: Kefu Chai kchai@redhat.com