mds: don't report repaired backtraces in damagetable, write back after repair, clean up scrub log #18538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batrick
reviewed
Oct 25, 2017
src/mds/ScrubStack.cc
Outdated
| << " (" << path << ") see " << g_conf->name | ||
| << " log and `damage ls` output for details"; | ||
| if (result.all_damage_repaired()) { | ||
| clog->warn() << "Scrub repaired inode " << in->ino() |
There was a problem hiding this comment.
From your fourth commit message "If we've repaired then we don't need to be at WRN", I got the impression this should be clog->info?
There was a problem hiding this comment.
good catch, pushed an update.
added 4 commits
October 31, 2017 16:37
People often are not using a tag with their scrub, let's not have the ugly "with tag ''" in that case. Signed-off-by: John Spray <john.spray@redhat.com>
Fixes: http://tracker.ceph.com/issues/18743 Signed-off-by: John Spray <john.spray@redhat.com>
Otherwise, if we restart the MDS right after the scrub, then scrub again, it will see the same inconsistency when it looks at the on-disk state. This involves adapting the use of ScrubHeader to be something writeable during scrub to record whether repair happened. Signed-off-by: John Spray <john.spray@redhat.com>
If we've repaired then we don't need to be at WRN and we don't need to advise the user to look up the damage detail. Signed-off-by: John Spray <john.spray@redhat.com>
batrick
approved these changes
Nov 2, 2017
batrick
added a commit
that referenced
this pull request
Nov 3, 2017
* refs/pull/18538/head: mds: clean up clog damage message when repairing mds: flush after scrub repairs mds: don't report repaired backtraces in damagetable mds: cleaner scrub complete log msg Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/18743