cmake: do not link against librados.a #18576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdurgin
approved these changes
Oct 27, 2017
a test for librados should be only depending on librados Signed-off-by: Kefu Chai <kchai@redhat.com>
* in hope to shrink the test, and the debug-info rpm package * also add librados to radostest's target_link_libraries(), otherwise we might run into linker order issue, like Undefined reference in /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/librados/test.cc:61 to `rados_application_enable' Signed-off-by: Kefu Chai <kchai@redhat.com>
link librados.so in hope to reduce the size of librdb, also the size of debug-info. Signed-off-by: Kefu Chai <kchai@redhat.com>
rados_a is librados.a, which is not neeeded anymore. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-cmake-no-rados_a
branch
from
13bc955
to
d5c9933
Compare
|
pushed to ceph/ceph-ci:wip-18576-kefu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in hope to reduce the size of debug-info a little bit