MDSMonitor: only clog changes to active #18600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcsp PTAL. |
jcsp
suggested changes
Oct 31, 2017
src/mon/MDSMonitor.cc
Outdated
| @@ -738,7 +738,7 @@ bool MDSMonitor::prepare_beacon(MonOpRequestRef op) | |||
| info->state_seq = seq; | |||
| }); | |||
|
|
|||
| if (state == MDSMap::STATE_ACTIVE) { | |||
| if (info.state != MDSMap::STATE_ACTIVE && state == MDSMap::STATE_ACTIVE) { | |||
There was a problem hiding this comment.
info is a reference that will have been modified in place by modify_daemon, so I don't think this will ever be true. Probably can just swap this block with the preceding one, or be even more explicit by adding an old_state temporarily for this check?
There was a problem hiding this comment.
Hmm, now I'm not sure how this solution actually worked for me (probably my testing was not right). I'll fix this...
Otherwise we get constant INFO messages that an MDS is active. Fixes: http://tracker.ceph.com/issues/21959 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
@jcsp PTAL. |
jcsp
approved these changes
Nov 7, 2017
|
retest this please |
batrick
added a commit
that referenced
this pull request
Nov 16, 2017
* refs/pull/18600/head: MDSMonitor: only clog changes to active Reviewed-by: John Spray <john.spray@redhat.com> Reviewed-by: João Eduardo Luís <joao@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we get constant INFO messages that an MDS is active.
Fixes: http://tracker.ceph.com/issues/21959
Signed-off-by: Patrick Donnelly pdonnell@redhat.com