luminous: RGWCrashError: RGW will crash if a putting lc config request does not include an ID tag in the request xml #18765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to AWS S3, this header must be used as a message integrity check to verify that the request body was not corrupted in transit. Content-MD5 is the base64-encoded 128-bit MD5 digest of the data Signed-off-by: Enming Zhang <enming.zhang@umcloud.com> (cherry picked from commit 9c0abe6)
When a putting lc config request does not include an ID tag in lc configuration xml, RGW should generate a random ID for the lc configuration. At present RGW will crash when generate a random ID for lc configuration. Fixes: http://tracker.ceph.com/issues/21980 Signed-off-by: Enming Zhang <enming.zhang@umcloud.com> (cherry picked from commit 3d2f63d)
|
The crash itself will not manifest in Luminous yet, as far as the random changes also are not backported to Luminous, but shouldn't hurt backporting this patch if we have a clean rgw run |
When generating random bucket name and object name during loadgen processing, RGW will crash. The reason is calling "gen_rand_alphanumeric" with "cct = NULL". Fixes: http://tracker.ceph.com/issues/22006 Signed-off-by: Enming Zhang <enming.zhang@umcloud.com> (cherry picked from commit 7d02178)
|
@theanalyst I cherry-picked #18536 into this PR - is that what you're referring to? |
|
@theanalyst Nevermind, now I see it's #17972 and that itself depends on other major changes, so I'm beginning to doubt whether it will ever be backported? |
|
@smithfarm yeah, having said that this patch by itself isn't harmful, only that the crash itself wouldn't occur until the random changes, if we see clean rgw runs shouldn't hurt to have this in. |
|
@smithfarm @theanalyst Thank you~ |
|
Jenkins, retest this please. |
|
@smithfarm @theanalyst @cbodley ready for merge |
cbodley
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/22016
http://tracker.ceph.com/issues/22024