mgr/prometheus: add missing 'deep' state to PG_STATES in ceph-mgr prometheus plugin #18890
Conversation
pjjw
force-pushed
the
pjjw/prom-deep-scrub-state-missing
branch
from
69b48fc
to
12d4c6e
Compare
liewegas
changed the title
|
Can we make the module not throw 500s if there is an unrecognized pg state? |
|
@pjjw I've created a ticket to track this http://tracker.ceph.com/issues/22116, please could you add a Fixes: line to your commit message that references it. |
|
Could you also add a "Deep" section to doc/rados/operations/pg-states.rst? That is where I extracted the initial list of PG States. Maybe something like |
Agreed. #18903 |
|
@jcsp shall we backport the fixes of prometheus to luminous? |
|
@jan--f probably not that urgent. i just want to understand what level of stableness we want to support in the LTS' mgr plugin. |
|
@pjjw please can you update the commit message to add the line "Fixes: http://tracker.ceph.com/issues/22116", so that this is easier to track when backporting etc. |
|
@tchaikov yes, we should backport, but no special urgency |
pjjw
force-pushed
the
pjjw/prom-deep-scrub-state-missing
branch
2 times, most recently
from
f1842d0
to
07d533d
Compare
|
Sorry for radio silence, this is usually weekend work for me @jan--f I took a stab at describing the 'deep' state, and also added some detail to the 'scrubbing' state (based on my limited understanding) - let me know if that doc change looks good. |
pjjw
force-pushed
the
pjjw/prom-deep-scrub-state-missing
branch
3 times, most recently
from
600949f
to
ea4252e
Compare
…metheus plugin without this the endpoint throws 500s when any PG is doing a deep scrub. Signed-off-by: Peter Woodman <peter@shortbus.org> Fixes: http://tracker.ceph.com/issues/22116
…ing' state to differentiate from 'deep' state Signed-off-by: Peter Woodman <peter@shortbus.org>
pjjw
force-pushed
the
pjjw/prom-deep-scrub-state-missing
branch
from
ea4252e
to
dff64a2
Compare
|
anything else i need to do to get this merged? slightly unclear from the contributing doc if I need to send a git patch over email. |
|
@pjjw you're all set, this is just waiting until someone picks it up and runs it through a test suite |
|
adding needs-qa so it'd be easier for someone to notice this PR. =) |
without this the endpoint throws 500s when any PG is doing a deep scrub