rgw: add rewrite cmd and options into radosgw-admin usage and doc #18918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscollin
requested changes
Nov 14, 2017
ZVampirEM77
force-pushed
the
wip-em-rewrite-cmd
branch
from
fe12967
to
881be6c
Compare
|
@joscollin done~ |
cbodley
approved these changes
Nov 14, 2017
|
@joscollin feel free to merge this once you approve |
joscollin
requested changes
Nov 14, 2017
ZVampirEM77
force-pushed
the
wip-em-rewrite-cmd
branch
from
881be6c
to
fd7e2be
Compare
|
@joscollin I have fixed the jenkins check error, do you mind to review again? |
joscollin
requested changes
Nov 15, 2017
There was a problem hiding this comment.
I would suggest the doc update along with this PR.
https://github.com/ceph/ceph/blob/master/doc/man/8/radosgw-admin.rst
By the way, there is another PR in progress that updates the other bucket * commands:
#18267
ZVampirEM77
force-pushed
the
wip-em-rewrite-cmd
branch
from
fd7e2be
to
74bb827
Compare
|
@joscollin done~ |
joscollin
changed the title
joscollin
requested changes
Nov 15, 2017
src/rgw/rgw_admin.cc
Outdated
| cout << " --max-rewrite-size specify the max object size condition for bucket rewrite (default ULLONG_MAX)\n"; | ||
| cout << " --min-rewrite-stripe-size specify the min stripe size condition for object rewrite,\n"; | ||
| cout << " default value is set to 0, in that case the specified object\n"; | ||
| cout << " will always be rewritten for restriping\n"; |
There was a problem hiding this comment.
Usage is a shorter version of the actual description in the doc. So I think this can be shortened as
specify the min stripe size condition for object rewrite (default 0). What do you say ?
+ radosgw-admin object rewrite + radosgw-admin bucket rewrite + --min-rewrite-size + --max-rewrite-size + --min-rewrite-stripe-size Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
ZVampirEM77
force-pushed
the
wip-em-rewrite-cmd
branch
from
74bb827
to
cefa401
Compare
|
@joscollin done~ |
joscollin
changed the title
joscollin
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Enming Zhang enming.zhang@umcloud.com