Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-disk: create deprecation warnings #18988

Merged
merged 2 commits into from Nov 17, 2017

Conversation

Projects
None yet
4 participants
@alfredodeza
Copy link
Contributor

commented Nov 17, 2017

Adds a banner-like deprecation warning for ceph-disk, and a doc section to help ceph-disk users what the correct way of migrating or consuming ceph-volume would be, with the noted exception of encryption

@@ -17,6 +17,33 @@ that may have been deployed with ``ceph-disk``.
* :ref:`ceph-volume-lvm`
* :ref:`ceph-volume-simple`


migrating

This comment has been minimized.

Copy link
@liewegas

liewegas Nov 17, 2017

Member

Migrating

try:
args.func(args)
except Exception:
# warn on any exception when not running with verbosity

This comment has been minimized.

Copy link
@liewegas

liewegas Nov 17, 2017

Member

is this backwards? this looks like the verbose path

This comment has been minimized.

Copy link
@alfredodeza

alfredodeza Nov 17, 2017

Author Contributor

Yes, my wording is backwards, hah!

alfredodeza added some commits Nov 17, 2017

doc/ceph-volume create a migration section to help users coming from …
…ceph-disk

Signed-off-by: Alfredo Deza <adeza@redhat.com>

@alfredodeza alfredodeza force-pushed the wip-rm22154 branch from 75a908a to e433efe Nov 17, 2017

@andrewschoen andrewschoen merged commit 664a2f9 into master Nov 17, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@andrewschoen andrewschoen deleted the wip-rm22154 branch Nov 17, 2017

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2017

@liewegas Should we backport this to luminous?

(N.B. I checked the Luminous v12.2.0 and v12.2.1 release notes and didn't find any mention of ceph-disk being deprecated.)

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2017

@smithfarm it was already backported here #18989

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2017

@andrewschoen OK. Would it make sense to add something to PendingReleaseNotes?

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2017

@smithfarm sure, that sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.