ceph-disk: create deprecation warnings #18988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
reviewed
Nov 17, 2017
doc/ceph-volume/index.rst
Outdated
| @@ -17,6 +17,33 @@ that may have been deployed with ``ceph-disk``. | |||
| * :ref:`ceph-volume-lvm` | |||
| * :ref:`ceph-volume-simple` | |||
|
|
|||
|
|
|||
| migrating | |||
liewegas
reviewed
Nov 17, 2017
src/ceph-disk/ceph_disk/main.py
Outdated
| try: | ||
| args.func(args) | ||
| except Exception: | ||
| # warn on any exception when not running with verbosity |
There was a problem hiding this comment.
is this backwards? this looks like the verbose path
There was a problem hiding this comment.
Yes, my wording is backwards, hah!
added 2 commits
November 17, 2017 13:38
Signed-off-by: Alfredo Deza <adeza@redhat.com> Fixes: http://tracker.ceph.com/issues/22154
…ceph-disk Signed-off-by: Alfredo Deza <adeza@redhat.com>
alfredodeza
force-pushed
the
wip-rm22154
branch
from
75a908a
to
e433efe
Compare
andrewschoen
approved these changes
Nov 17, 2017
|
@liewegas Should we backport this to luminous? (N.B. I checked the Luminous v12.2.0 and v12.2.1 release notes and didn't find any mention of ceph-disk being deprecated.) |
|
@smithfarm it was already backported here #18989 |
|
@andrewschoen OK. Would it make sense to add something to |
|
@smithfarm sure, that sounds reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a banner-like deprecation warning for ceph-disk, and a doc section to help ceph-disk users what the correct way of migrating or consuming ceph-volume would be, with the noted exception of encryption