Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luminous: rgw segfaults after running radosgw-admin data sync init #19071

Merged
merged 3 commits into from
Jan 19, 2018
Merged

luminous: rgw segfaults after running radosgw-admin data sync init #19071

merged 3 commits into from
Jan 19, 2018

Conversation

smithfarm
Copy link
Contributor

theanalyst and others added 3 commits November 21, 2017 10:03
@theanalyst @smithfarm
rgw: data sync: set num_shards when building full maps
4421208 
When radosgw-admin data sync init is called on a cluster, the next run
of rgw crashes as when it processes ListBucketIndexesCR, num_shards
isn't set which is later referenced in ListBucketIndexesCR. Setting the
n sync_info.num_shards correctly to handle this case

Fixes: http://tracker.ceph.com/issues/22083
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 4015a57)
@cbodley @smithfarm
dencoder/rgw: expose rgw sync status types
239a2f8 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 662b024)
@cbodley @smithfarm
rgw: set num_shards on 'radosgw-admin data sync init'
58d6d04 
Fixes: http://tracker.ceph.com/issues/22083

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 90e860c)
@smithfarm smithfarm self-assigned this Nov 21, 2017
@smithfarm smithfarm added this to the luminous milestone Nov 21, 2017
@smithfarm smithfarm added rgw and removed core labels Nov 21, 2017
@smithfarm
Copy link
Contributor Author 

CMake Error at src/CMakeLists.txt:676 (add_subdirectory):
  The source directory

    /home/jenkins-build/build/workspace/ceph-pull-requests/src/lua

  does not contain a CMakeLists.txt file.


CMake Error at cmake/modules/MergeStaticLibraries.cmake:21 (message):
  liblua not a valid target
Call Stack (most recent call first):
  src/cls/CMakeLists.txt:269 (merge_static_libraries)

@smithfarm
Copy link
Contributor Author

Jenkins re-test this please

@smithfarm smithfarm mentioned this pull request Nov 21, 2017
Merged
@smithfarm
Copy link
Contributor Author

Looks like luminous has a transient crash in test_objectstore_memstore.sh . . . this is the second PR I'm seeing it in.

    -2> 2017-11-21 11:09:05.985217 7f4c3b836700 -1 --- buffer lengths mismatch expected 0x56a61 != actual 0x3f232
    -1> 2017-11-21 11:09:05.994612 7f4c3b836700 -1 --- buffer mismatch between offset 0x3f232 and 0x0, total 0x3f232
     0> 2017-11-21 11:09:06.016278 7f4c3b836700 -1 /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/objectstore/store_test.cc: In function 'virtual void SyntheticWorkloadState::C_SyntheticOnReadable::finish(int)' thread 7f4c3b836700 time 2017-11-21 11:09:06.015226
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/objectstore/store_test.cc: 3358: FAILED assert(bl_eq(state->contents[hoid].data, r2))

 ceph version 12.2.1-832-g6bf51da (6bf51dab4b61500e74ca89ad221b3178163ccaae) luminous (stable)
 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x102) [0x7f4c403dce02]
 2: (SyntheticWorkloadState::C_SyntheticOnReadable::finish(int)+0x372) [0x557b6b5ce532]
 3: (Context::complete(int)+0x9) [0x557b6b5a8aa9]
 4: (Finisher::finisher_thread_entry()+0x460) [0x7f4c403db010]
 5: (()+0x76ba) [0x7f4c497326ba]
 6: (clone()+0x6d) [0x7f4c3f0713dd]
 NOTE: a copy of the executable, or `objdump -rdS <executable>` is needed to interpret this.

@theanalyst theanalyst mentioned this pull request Nov 22, 2017
Closed
@yuriw
Copy link
Contributor

yuriw commented Jan 18, 2018

luminous rgw => wip-yuri3-testing-2018-01-18-0053

@yuriw
Copy link
Contributor

yuriw commented Jan 19, 2018

@smithfarm @theanalyst @cbodley ready for merge

@yuriw
Copy link
Contributor

yuriw commented Jan 19, 2018

test this please

@liewegas liewegas merged commit 1a69f3e into ceph:luminous Jan 19, 2018
@smithfarm smithfarm deleted the wip-22181-luminous branch January 20, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theanalyst theanalyst theanalyst approved these changes

@cbodley cbodley cbodley approved these changes

Assignees

@smithfarm smithfarm

Labels
bug-fix luminous-batch-1 rgw wip-yuri3-testing
Projects
None yet
Milestone
luminous
Development

Successfully merging this pull request may close these issues.
5 participants
@smithfarm @yuriw @theanalyst @cbodley @liewegas