Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw,common,rbd: s/boost::regex/std::regex/ #19393

Merged
merged 7 commits into from
Jan 10, 2018

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Dec 8, 2017

No description provided.

@tchaikov
Copy link
Contributor Author

tchaikov commented Dec 8, 2017

see also #15498

@tchaikov tchaikov changed the title rgw,common,rgw: s/boost::regex/std::regex/ rgw,common,rbd: s/boost::regex/std::regex/ Jan 8, 2018
@tchaikov
Copy link
Contributor Author

tchaikov commented Jan 8, 2018

rebased against master to resolve conflicts.

@tchaikov
Copy link
Contributor Author

tchaikov commented Jan 8, 2018

@yuriw could you help include this PR in your next qa batch?

@tchaikov tchaikov added the DNM label Jan 8, 2018
@tchaikov tchaikov force-pushed the wip-no-more-gcc-4.8 branch 4 times, most recently from 4ebeae0 to 1b2ae82 Compare January 9, 2018 06:14
* src/tools/rbd/*: s/boost::regex/std::regex/
* */CMakeLists.txt: do not link against Boost_REGEX_LIBRARY
    anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>
This reverts commit af8d9bd.

Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
we now use std::regex now, since we've dropped the support of GCC 4.8

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov merged commit 3f45280 into ceph:master Jan 10, 2018
@tchaikov tchaikov deleted the wip-no-more-gcc-4.8 branch January 10, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants