-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw,common,rbd: s/boost::regex/std::regex/ #19393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-no-more-gcc-4.8
branch
from
December 8, 2017 06:31
5c88078
to
422d96d
Compare
see also #15498 |
tchaikov
force-pushed
the
wip-no-more-gcc-4.8
branch
8 times, most recently
from
December 8, 2017 13:31
dd89381
to
a1aaca5
Compare
adamemerson
approved these changes
Dec 8, 2017
tchaikov
force-pushed
the
wip-no-more-gcc-4.8
branch
from
January 8, 2018 12:00
a1aaca5
to
8c9f685
Compare
tchaikov
changed the title
rgw,common,rgw: s/boost::regex/std::regex/
rgw,common,rbd: s/boost::regex/std::regex/
Jan 8, 2018
tchaikov
force-pushed
the
wip-no-more-gcc-4.8
branch
from
January 8, 2018 12:12
8c9f685
to
d3dcc62
Compare
rebased against master to resolve conflicts. |
@yuriw could you help include this PR in your next qa batch? |
tchaikov
force-pushed
the
wip-no-more-gcc-4.8
branch
4 times, most recently
from
January 9, 2018 06:14
4ebeae0
to
1b2ae82
Compare
* src/tools/rbd/*: s/boost::regex/std::regex/ * */CMakeLists.txt: do not link against Boost_REGEX_LIBRARY anymore. Signed-off-by: Kefu Chai <kchai@redhat.com>
This reverts commit af8d9bd. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
we now use std::regex now, since we've dropped the support of GCC 4.8 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-no-more-gcc-4.8
branch
from
January 9, 2018 09:29
1b2ae82
to
142f2a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.