os/bluestore: using macro OBJECT_MAX_SIZE to check osd_max_object_size. #19622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majianpeng
force-pushed
the
bluestore-check-obj-max-siz
branch
from
20fc294
to
1762549
Compare
xiexingguo
reviewed
Dec 22, 2017
src/os/bluestore/BlueStore.cc
Outdated
| if (cct->_conf->get_val<uint64_t>("osd_max_object_size") >= | ||
| 4*1024*1024*1024ull) { | ||
| derr << __func__ << " osd_max_object_size >= 4GB; BlueStore has hard limit of 4GB." << dendl; | ||
| if (cct->_conf->get_val<uint64_t>("osd_max_object_size") > |
majianpeng
force-pushed
the
bluestore-check-obj-max-siz
branch
from
1762549
to
db85d62
Compare
|
sorry for late response. Update |
liewegas
approved these changes
Jan 3, 2018
|
@majianpeng need rebase |
majianpeng
force-pushed
the
bluestore-check-obj-max-siz
branch
from
db85d62
to
6ea6cce
Compare
|
update. please review. Thanks! |
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com