Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: using macro OBJECT_MAX_SIZE to check osd_max_object_size. #19622

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
4 participants
@majianpeng
Copy link
Member

commented Dec 21, 2017

Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com

@majianpeng majianpeng force-pushed the majianpeng:bluestore-check-obj-max-siz branch from 20fc294 to 1762549 Dec 22, 2017

if (cct->_conf->get_val<uint64_t>("osd_max_object_size") >=
4*1024*1024*1024ull) {
derr << __func__ << " osd_max_object_size >= 4GB; BlueStore has hard limit of 4GB." << dendl;
if (cct->_conf->get_val<uint64_t>("osd_max_object_size") >

This comment has been minimized.

Copy link
@xiexingguo

This comment has been minimized.

Copy link
@liewegas

liewegas Dec 29, 2017

Member

yeah, please keep it >=

@liewegas
Copy link
Member

left a comment

.

@majianpeng majianpeng force-pushed the majianpeng:bluestore-check-obj-max-siz branch from 1762549 to db85d62 Jan 3, 2018

@majianpeng

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2018

sorry for late response. Update

@liewegas liewegas added the needs-qa label Jan 3, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2018

@majianpeng need rebase

@majianpeng majianpeng force-pushed the majianpeng:bluestore-check-obj-max-siz branch from db85d62 to 6ea6cce Jan 9, 2018

@majianpeng

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2018

update. please review. Thanks!

os/bluestore: using macro OBJECT_MAX_SIZE to check object max size.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

@liewegas liewegas merged commit bac997a into ceph:master Jan 10, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.