osd: Making use of find to reduce computational complexity #19732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
previously requested changes
Jan 2, 2018
liewegas
requested changes
Jan 2, 2018
src/osd/PrimaryLogPG.cc
Outdated
| @@ -424,7 +424,7 @@ void PrimaryLogPG::on_local_recover( | |||
| bool got = obc->get_recovery_read(); | |||
| assert(got); | |||
|
|
|||
| assert(recovering.count(obc->obs.oi.soid)); | |||
| assert(recovering.find(obc->obs.oi.soid) != recovering.end()); | |||
There was a problem hiding this comment.
This changes aren't helpful/useful.. the complexity is the same and they are more verbose.
The point is get rid of patterns like:
if (foo.count(bar) && foo[bar] == baz) {
where a count() precedes an operator[] call. That is two lookups but can be reduced to 1 by using an iterator and comparing to end().
src/osd/PrimaryLogPG.cc
Outdated
| @@ -755,7 +761,7 @@ void PrimaryLogPG::maybe_force_recovery() | |||
| ++it) { | |||
| if (*it == get_primary()) continue; | |||
| pg_shard_t peer = *it; | |||
| if (peer_missing.count(peer) && | |||
| if (peer_missing.find(peer) != peer_missing.end() && | |||
There was a problem hiding this comment.
Like here:
auto it = peer_missing.find(peer);
if (it != peer_missing.end() &&
!it->second.get_rmissing.empty()) {
...
Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>
shinobu-x
force-pushed
the
using_find_primarylogpg
branch
from
1fbe699
to
79c0e75
Compare
shinobu-x
changed the title
|
@liewegas Please check when you get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shinobu Kinjo shinobu@redhat.com