Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osdc: Do not use lock_guard as unique_lock #19756

Merged
merged 1 commit into from
Jan 4, 2018
Merged

osdc: Do not use lock_guard as unique_lock #19756

merged 1 commit into from
Jan 4, 2018

Conversation

shinobu-x
Copy link
Contributor

Signed-off-by: Shinobu Kinjo shinobu@redhat.com

@shinobu-x
osdc: Do not use lock_guard as unique_lock
dae91f3 
Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>
@batrick batrick added the core label Jan 3, 2018
@gregsfortytwo
Copy link
Member

@adamemerson, looking at the patch I think this was just a typo?

adamemerson
adamemerson approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@adamemerson adamemerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is embarrassing.

(Though now you can get rid of those typedefs and just use uniquely/guardedly/sharingly lock, if you want to.)

@gregsfortytwo gregsfortytwo merged commit 79e83d2 into ceph:master Jan 4, 2018
@gregsfortytwo
Copy link
Member

If it makes you feel better, grepping tells me this wasn't actually in use. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamemerson adamemerson adamemerson approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shinobu-x @gregsfortytwo @adamemerson @batrick