ceph-volume: adds --crush-device-class flag for lvm prepare and create #19949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfredodeza
approved these changes
Jan 15, 2018
tchaikov
reviewed
Jan 16, 2018
src/ceph-disk/ceph_disk/main.py
Outdated
| @@ -2755,7 +2758,7 @@ def create_key(self): | |||
| bootstrap = self.args.prepare_key_template.format(cluster=cluster, | |||
| statedir=STATEDIR) | |||
| path = self.get_mount_point() | |||
| secrets = LockboxSecrets(self.args) | |||
| secrets = LockboxSecrets(self.args, crush_device_class=self.args.crush_device_class) | |||
There was a problem hiding this comment.
nit, i don't think we need to pass crush_device_classa separately if it's already in self.args.
2 tasks
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
andrewschoen
force-pushed
the
wip-bz1498521
branch
from
47087b4
to
21f4594
Compare
|
@alfredodeza @tchaikov I've removed the |
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume lvm centos7-bluestore-create |
1 similar comment
|
jenkins test ceph-volume lvm centos7-bluestore-create |
Move the terminal.success to the methods that have access to the correct osd_id so that they do not print None for the osd_id in the log message. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
|
jenkins test ceph-volume lvm all |
alfredodeza
added a commit
that referenced
this pull request
Feb 1, 2018
luminous: ceph-volume: adds --crush-device-class flag for lvm prepare and create #19949 Reviewed-by: Alfredo Deza <adeza@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the new method of setting the crush device class through the json given to the
osd newcommand. Introduced here: #19939Needs this for ceph-ansible support and for CI testing: ceph/ceph-ansible#2318
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1498521