luminous: ceph-volume: adds --crush-device-class flag for lvm prepare and create #19949 #20239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit bf468bc)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 11da218)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 36a388d)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 3404d8b)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 21f4594)
Move the terminal.success to the methods that have access to the correct osd_id so that they do not print None for the osd_id in the log message. Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit c9f7689)
|
jenkins test ceph-volume tox |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #19949
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1498521
needs backport of #19939