librbd: group and snapshot cleanup #19990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runsisi
reviewed
Jan 18, 2018
src/test/cli/rbd/help.t
Outdated
| diff Print extents that differ since a | ||
| previous snap, or image creation. | ||
| disk-usage (du) Show disk usage stats for pool, image | ||
| or snapshot |
There was a problem hiding this comment.
need a period(.) at the end of the help message
dillaman
force-pushed
the
wip-group-cleanup
branch
from
7aa2a55
to
b3c8a4b
Compare
added 12 commits
January 26, 2018 10:32
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The methods are used by the luminous release of librbd but are essentially no-ops since group support was removed from the API. However, we need to prevent odd interactions once a new client creates a group and uses an older client to manipulate the image. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
When an image is added to a group, set the group op feature bit and when removed, clear the bit. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Added a new cls 'snapshot_get' method that retrieves all snapshot specific details to avoid the need to add a new cls method to retrieve each individual snapshot data field. The cls 'get_snapshot_namespace' method has been dropped since Luminous clients will treat that as a user-generated snapshot (and that's all that is supported by Luminous clients). The cls 'get_snapshot_timestamp' method has been deprecated and can be removed once <=Luminous clients are no longer supported. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-group-cleanup
branch
from
b3c8a4b
to
a5b0a8d
Compare
trociny
reviewed
Jan 27, 2018
src/pybind/rbd/rbd.pyx
Outdated
| rbd_group_info_cleanup(&info, sizeof(info)) | ||
| return result | ||
|
|
||
| def id(self): |
There was a problem hiding this comment.
@dillaman I suppose this redefinition of id() method was added unintentionally here?
trociny
reviewed
Jan 27, 2018
src/pybind/rbd/rbd.pyx
Outdated
|
|
||
| * ``pool`` (int) - id of the group pool | ||
|
|
||
| * ``name`` (ste) - name of the group |
added 3 commits
January 27, 2018 08:02
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-group-cleanup
branch
from
a5b0a8d
to
9a93808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the operations feature w/ group operation when an image is added to a group. Cleanup and normalize the API and CLI for groups. Add a simple method for retrieving snapshots from the OSDs.