Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librbd: group and snapshot cleanup #19990

Merged
merged 15 commits into from
Jan 28, 2018
Merged

librbd: group and snapshot cleanup #19990

merged 15 commits into from
Jan 28, 2018

Commits on Jan 26, 2018

  1. test/librbd: treat empty features environment variable as old format 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    ac56e7b View commit details
    Browse the repository at this point in the history

  2. librbd: remove 'consistency' verbiage from group feature 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    4432e7e View commit details
    Browse the repository at this point in the history

  3. librbd: group image add/remove ops should notify update 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    0ce2c83 View commit details
    Browse the repository at this point in the history

  4. cls/rbd: cleanup helper method visibility 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    19a9c3b View commit details
    Browse the repository at this point in the history

  5. cls/rbd: removed unused snapshot feature bitmask 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    41c5f32 View commit details
    Browse the repository at this point in the history

  6. cls/rbd: add new op feature bits for groups and snap trash 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    c0801af View commit details
    Browse the repository at this point in the history

  7. cls/rbd: renamed image group add/remove/get operations 

    The methods are used by the luminous release of librbd but are essentially
no-ops since group support was removed from the API. However, we need to
prevent odd interactions once a new client creates a group and uses an
older client to manipulate the image.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    94dc5ae View commit details
    Browse the repository at this point in the history

  8. cls/rbd: automatically manage group op feature on images 

    When an image is added to a group, set the group op feature
bit and when removed, clear the bit.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    7cd13f8 View commit details
    Browse the repository at this point in the history

  9. librbd: simplified retrieving snapshots from image header 

    Added a new cls 'snapshot_get' method that retrieves all snapshot
specific details to avoid the need to add a new cls method to
retrieve each individual snapshot data field.

The cls 'get_snapshot_namespace' method has been dropped since Luminous
clients will treat that as a user-generated snapshot (and that's all
that is supported by Luminous clients). The cls 'get_snapshot_timestamp'
method has been deprecated and can be removed once <=Luminous clients
are no longer supported.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    4ad9d56 View commit details
    Browse the repository at this point in the history

  10. librbd: properly handle group snap add failure case 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    deba6b4 View commit details
    Browse the repository at this point in the history

  11. librbd: shorten the generated group image snapshot name 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    3c4e2c1 View commit details
    Browse the repository at this point in the history

  12. librbd: normalize image group C/C++ API 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    86772a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2018

  1. pybind/rbd: normalize image group API 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    36d3b17 View commit details
    Browse the repository at this point in the history

  2. rbd: dump op features in image info 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    471a5a9 View commit details
    Browse the repository at this point in the history

  3. rbd: normalize group command aliases 

    Signed-off-by: Jason Dillaman <dillaman@redhat.com>
    Jason Dillaman committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    9a93808 View commit details
    Browse the repository at this point in the history