Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon/OSDMonitor: rename outer name declaration to avoid shadowing #20032

Merged
merged 3 commits into from Jan 22, 2018
Merged

mon/OSDMonitor: rename outer name declaration to avoid shadowing #20032

merged 3 commits into from Jan 22, 2018

Conversation

liewegas
Copy link
Member

No description provided.

@liewegas
use stringsream::str(), not rdbuf()
918361e 
Fixes: http://tracker.ceph.com/issues/22715
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas
mon/OSDMonitor: squelch 'id' arg errors
0580f01 
Several commands use 'id' but for other types (e.g., vector<int64_t>).

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas
mon/OSDMonitor: rename outer name declaration to avoid shadowing
a03dacd 
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas
Copy link
Member Author

http://pulpito.ceph.com/sage-2018-01-22_16:28:42-rados-wip-sage3-testing-2018-01-22-0845-distro-basic-smithi/

@liewegas liewegas merged commit 92f7b56 into ceph:master Jan 22, 2018
@liewegas liewegas deleted the wip-name-shadowing branch January 22, 2018 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

Assignees
No one assigned
Labels
cleanup core wip-sage3-testing
Projects
None yet
Milestone
No milestone
2 participants
@liewegas @tchaikov