jewel: rgw: resharding needs to set back the bucket ACL after link #20039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oritwas
changed the title
|
@oritwas Can you add something to the commit message explaining why this can't be cherry-picked from master? |
|
@yehudasa Please review. |
|
Integration testing: http://tracker.ceph.com/issues/21742#note-11 Will post a summary to the PR when the testing is complete. |
|
@yehudasa @cbodley This PR passed two RGW runs at http://tracker.ceph.com/issues/21742#note-11 Do you think it's ready to merge? |
|
@oritwas @smithfarm commit text should mention that this fix is a jewel only fix |
Jewel only fix. New implementation of resharding in Luminous. Fixes: http://tracker.ceph.com/issues/22703 Signed-off-by: Orit Wasserman <owasserm@redhat.com>
oritwas
force-pushed
the
wip-rgw-jewel-22703
branch
from
4ea106b
to
dde61bc
Compare
yehudasa
approved these changes
Feb 5, 2018
theanalyst
pushed a commit
to theanalyst/ceph
that referenced
this pull request
Apr 20, 2018
Jewel only fix. New implementation of resharding in Luminous. Fixes:http://tracker.ceph.com/issues/22124 Signed-off-by: Orit Wasserman <owasserm@redhat.com> src/rgw/rgw_admin.cc RGWBucketAdminOp::link : setattrs not a part of this changeset yet (pr ceph#20039 which was later superceded by ceph#20421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cannot be cherry-picked because of different implementation in luminous and master
Jewel tracker: http://tracker.ceph.com/issues/22703