rgw: fix index cancel op miss update header #20396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
requested changes
Feb 13, 2018
src/cls/rgw/cls_rgw.cc
Outdated
|
|
||
| if (op.log_op && !header.syncstopped) { | ||
| return write_bucket_header(hctx, &header); | ||
| return 0; |
There was a problem hiding this comment.
it looks like this if block is missing a closing }
which is funny, because the jenkins make check succeeded - so i guess we aren't building cls_rgw for that
Signed-off-by: Tianshan Qu <tianshan@xsky.com>
tianshan
force-pushed
the
cancel_op_miss_update_header
branch
from
2467016
to
690482d
Compare
|
@cbodley fixed |
cbodley
approved these changes
Feb 14, 2018
|
Does this pull cause quota can't work ? |
|
@TaveMyliuX don't think so, what's your phenomenon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tianshan Qu tianshan@xsky.com