Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/ops: rpm: provide files moved from ceph-test … #20401

Merged
merged 1 commit into from
Jul 22, 2018
Merged

build/ops: rpm: provide files moved from ceph-test … #20401

merged 1 commit into from
Jul 22, 2018

Conversation

smithfarm
Copy link
Contributor

@smithfarm smithfarm commented Feb 12, 2018 •
edited
Loading

d7b493a moved three binaries from the
ceph-test package to other packages, causing trouble with upgrades in
test lab environments (users typically do not install the ceph-test
package).

While the original upgrade troubles have already been addressed, RPM
has a "Provides" mechanism for easing the pain, so it makes sense to
use it.

Fixes: http://tracker.ceph.com/issues/22558
Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm smithfarm requested a review from yuriw February 12, 2018 16:07
@smithfarm
Copy link
Contributor Author

smithfarm commented Apr 6, 2018 •
edited
Loading

http://pulpito.ceph.com/smithfarm-2018-04-06_08:00:20-rados-wip-smithfarm-testing-distro-basic-smithi/

200 jobs passed, 2 failures ("SLOW_OPS in cluster log") that are, I believe, unrelated

@smithfarm
Copy link
Contributor Author

@tchaikov I'm thinking this might allow us to revert b07aa21 since the hard versioned requires was originally dropped by 924f85f because it was causing bogus test failures?

Obviously, it will have to be tested.

@smithfarm smithfarm requested a review from tchaikov April 6, 2018 20:13
tchaikov
tchaikov approved these changes Apr 7, 2018
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as long as the upgrade tests pass.

@smithfarm
Copy link
Contributor Author

smithfarm commented Apr 8, 2018 •
edited
Loading

@tchaikov The upgrade tests will have to be fixed up, first, I guess - see e.g.

@smithfarm smithfarm changed the title build/ops: rpm: provide files moved from ceph-test build/ops: rpm: provide files moved from ceph-test … May 3, 2018
@smithfarm smithfarm mentioned this pull request May 3, 2018
Merged
@smithfarm
build/ops: rpm: provide files moved from ceph-test
341d985 
d7b493a moved three binaries from the
ceph-test package to other packages, causing trouble with upgrades in
test lab environments (users typically do not install the ceph-test
package).

While the original upgrade troubles have already been addressed, RPM
has a "Provides" mechanism for easing the pain, so it makes sense to
use it.

Fixes: http://tracker.ceph.com/issues/22558
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor Author

smithfarm commented Jul 21, 2018 •
edited
Loading

Since today's upgrade/luminous-x suite experience is better in mimic than in master, I cherry-picked the commit from this PR on top of mimic and pushed it to shaman for testing:

https://shaman.ceph.com/builds/ceph/wip-22558-mimic/75b4c172575df0c1345a1387b4b11c6ae3e81dd5/

teuthology-suite -k distro --machine-type smithi --email ncutler@suse.cz --priority 102 --ceph-repo https://github.com/ceph/ceph-ci.git --ceph wip-22558-mimic --suite-repo https://github.com/smithfarm/ceph.git --suite-branch wip-25056-mimic --suite upgrade/luminous-x --filter centos

pass http://pulpito.ceph.com/smithfarm-2018-07-24_02:09:48-upgrade:luminous-x-wip-22558-mimic-distro-basic-smithi/

@smithfarm
Copy link
Contributor Author

smithfarm commented Jul 21, 2018 •
edited
Loading

Actually, a single successful centos upgrade/luminous-x job should be enough to demonstrate that this PR does not introduce a regression. Here it is:

http://pulpito.ceph.com/smithfarm-2018-07-21_14:24:51-upgrade:luminous-x-wip-smithfarm-testing-distro-basic-smithi/2806177/

@smithfarm
Copy link
Contributor Author

jenkins re-test this please

@tchaikov tchaikov merged commit 98c3b19 into ceph:master Jul 22, 2018
@smithfarm smithfarm deleted the wip-22558 branch July 22, 2018 07:36
@tchaikov tchaikov mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@yuriw yuriw Awaiting requested review from yuriw

@ktdreyer ktdreyer Awaiting requested review from ktdreyer

@tserong tserong Awaiting requested review from tserong

@b-ranto b-ranto Awaiting requested review from b-ranto

Assignees
No one assigned
Labels
build/ops wip-smithfarm-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smithfarm @tchaikov @batrick