-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filestore: include <linux/falloc.h> #20415
Conversation
src/os/filestore/FileStore.h
Outdated
#ifndef FALLOC_FL_PUNCH_HOLE | ||
# define FALLOC_FL_PUNCH_HOLE 0x2 | ||
#ifdef __linux__ | ||
#include <linux/falloc.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you move this #include into FileStore.cc
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tchaikov yes, I've done it.
4fb0ba2
to
e758b97
Compare
@wumingqiao could you squash these two commits into a single one? and i think it will be ready for the rados qa run then. |
see ceph#7768 because we neither define FALLOC_FL_KEEP_SIZE nor include linux/falloc.h,this pull actually disable punching hole. Signed-off-by: wumingqiao <wumingqiao@inspur.com>
e758b97
to
200904f
Compare
@tchaikov Done as your wish. |
see #7768
because we neither define FALLOC_FL_KEEP_SIZE nor include linux/falloc.h,this pull actually disable punching hole.
Signed-off-by: wumingqiao wumingqiao@inspur.com