filestore: include <linux/falloc.h> #20415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Feb 14, 2018
src/os/filestore/FileStore.h
Outdated
| #ifndef FALLOC_FL_PUNCH_HOLE | ||
| # define FALLOC_FL_PUNCH_HOLE 0x2 | ||
| #ifdef __linux__ | ||
| #include <linux/falloc.h> |
There was a problem hiding this comment.
could you move this #include into FileStore.cc?
There was a problem hiding this comment.
@tchaikov yes, I've done it.
wumingqiao
force-pushed
the
wip-fallocate
branch
from
4fb0ba2
to
e758b97
Compare
|
@wumingqiao could you squash these two commits into a single one? and i think it will be ready for the rados qa run then. |
see ceph#7768 because we neither define FALLOC_FL_KEEP_SIZE nor include linux/falloc.h，this pull actually disable punching hole. Signed-off-by: wumingqiao <wumingqiao@inspur.com>
wumingqiao
force-pushed
the
wip-fallocate
branch
from
e758b97
to
200904f
Compare
|
@tchaikov Done as your wish. |
tchaikov
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #7768
because we neither define FALLOC_FL_KEEP_SIZE nor include linux/falloc.h，this pull actually disable punching hole.
Signed-off-by: wumingqiao wumingqiao@inspur.com