Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends random.h: numeric types relaxed to compatible types (with #20670

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
5 participants
@chardan
Copy link
Contributor

commented Mar 1, 2018

Extends random.h: numeric types relaxed to compatible types (with appropriate distributions), fixes 2-parameter calling convention; OOP interface now publishes engine and device types and allows
appropriate seed types.

These changes are the result of direct experience porting Ceph code away from rand(), and a prerequisite for that further porting. They should be backward-compatible with the currently-published API.

These changes supercede "#18333".

Signed-off-by: Jesse Williamson jwilliamson@suse.de

@chardan chardan force-pushed the chardan:jfw-wip-rand_migration-core branch from 4574f56 to 5c3d046 Mar 1, 2018

@chardan chardan self-assigned this Mar 1, 2018

@chardan chardan requested review from cbodley and adamemerson Mar 1, 2018

@chardan chardan force-pushed the chardan:jfw-wip-rand_migration-core branch from 5c3d046 to 337e98b Mar 1, 2018

Jesse Williamson
Extends random.h: numeric types relaxed to compatible types (with
appropriate distributions), fixes 2-parameter calling convention;
OOP interface now publishes engine and device types and allows
appropriate seed types.

These changes are the result of direct experience porting Ceph
code away from rand(), and a prerequisite for that further porting.

Signed-off-by: Jesse Williamson <jwilliamson@suse.de>
@adamemerson
Copy link
Contributor

left a comment

Looks excellent to me.

@chardan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2018

ping... any further comments here?

@adamemerson

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2018

I am happy with it.

@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit 6ad4bf0 into ceph:master Apr 13, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
@cbodley

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2018

this pr appears to have broken the messenger. i'm seeing all clients generate the same random 'nonce', so servers can't distinguish between clients with the same address. did we break something with the seeding on first use? more at http://tracker.ceph.com/issues/23778

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2018

opened #21567 to revert the change from boost::optional to std::optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.