Extends random.h: numeric types relaxed to compatible types (with #20670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chardan
force-pushed
the
jfw-wip-rand_migration-core
branch
from
4574f56
to
5c3d046
Compare
chardan
force-pushed
the
jfw-wip-rand_migration-core
branch
from
5c3d046
to
337e98b
Compare
appropriate distributions), fixes 2-parameter calling convention; OOP interface now publishes engine and device types and allows appropriate seed types. These changes are the result of direct experience porting Ceph code away from rand(), and a prerequisite for that further porting. Signed-off-by: Jesse Williamson <jwilliamson@suse.de>
adamemerson
approved these changes
Mar 20, 2018
|
ping... any further comments here? |
|
I am happy with it. |
|
failed tests are |
|
this pr appears to have broken the messenger. i'm seeing all clients generate the same random 'nonce', so servers can't distinguish between clients with the same address. did we break something with the seeding on first use? more at http://tracker.ceph.com/issues/23778 |
|
opened #21567 to revert the change from boost::optional to std::optional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends random.h: numeric types relaxed to compatible types (with appropriate distributions), fixes 2-parameter calling convention; OOP interface now publishes engine and device types and allows
appropriate seed types.
These changes are the result of direct experience porting Ceph code away from rand(), and a prerequisite for that further porting. They should be backward-compatible with the currently-published API.
These changes supercede "#18333".
Signed-off-by: Jesse Williamson jwilliamson@suse.de