random: revert change from boost::optional to std::optional #21567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
changed the title
somehow this was breaking the seeding of thread-local engines on gcc. we'll have to investigate this further, but for now i'm reverting this piece to get messengers working again Fixes: http://tracker.ceph.com/issues/23778 Signed-off-by: Casey Bodley <cbodley@redhat.com>
tchaikov
approved these changes
Apr 20, 2018
|
tests running at http://pulpito.ceph.com/cbodley-2018-04-20_19:15:33-rgw-wip-cbodley-testing-distro-basic-smithi/ no unexpected failures so far |
chardan
reviewed
Apr 21, 2018
|
@chardan we've been using std::optional without any problems, so i'm not sure why it's acting up here. maybe some interaction with thread_local? |
|
@cbodley That's my best guess right now-- still needs further investigation. TBH, as best as I can tell there shouldn't have been any issue, but reality didn't seem to match! It's possible that it's a compiler issue, but I don't have any evidence yet. |
yuriw
pushed a commit
that referenced
this pull request
Apr 26, 2018
Snapshot deletion requests on snap ids larger than the snap_seq of the pool will leave the pool in a state with snap_seq being less than max(removed_snaps). This is bad because further deletion requests to a pool in this state might crash the mon in some cases: the deletion also inserts the new snap_seq into the removed_snaps set -- which might already exist in this case and trigger an assert. Such bad requests will be generated by rbd clients without a fix for issue #21567. The change in OSDMonitor prevents pools from getting into this state and may prevent old broken clients from incorrectly deleting snaps. The change in osd_types avoids a crash if a pool is already in this state. Fixes #18746 Signed-off-by: Paul Emmerich <paul.emmerich@croit.io>
emmericp
pushed a commit
to croit/ceph
that referenced
this pull request
Apr 28, 2018
Snapshot deletion requests on snap ids larger than the snap_seq of the pool will leave the pool in a state with snap_seq being less than max(removed_snaps). This is bad because further deletion requests to a pool in this state might crash the mon in some cases: the deletion also inserts the new snap_seq into the removed_snaps set -- which might already exist in this case and trigger an assert. Such bad requests will be generated by rbd clients without a fix for issue ceph#21567. The change in OSDMonitor prevents pools from getting into this state and may prevent old broken clients from incorrectly deleting snaps. The change in osd_types avoids a crash if a pool is already in this state. Fixes ceph#18746 Signed-off-by: Paul Emmerich <paul.emmerich@croit.io> (cherry picked from commit f42a6ba)
emmericp
pushed a commit
to croit/ceph
that referenced
this pull request
Apr 29, 2018
Snapshot deletion requests on snap ids larger than the snap_seq of the pool will leave the pool in a state with snap_seq being less than max(removed_snaps). This is bad because further deletion requests to a pool in this state might crash the mon in some cases: the deletion also inserts the new snap_seq into the removed_snaps set -- which might already exist in this case and trigger an assert. Such bad requests will be generated by rbd clients without a fix for issue ceph#21567. The change in OSDMonitor prevents pools from getting into this state and may prevent old broken clients from incorrectly deleting snaps. The change in osd_types avoids a crash if a pool is already in this state. Fixes ceph#18746 Signed-off-by: Paul Emmerich <paul.emmerich@croit.io> (cherry picked from commit f42a6ba) Conflicts: src/osd/osd_types.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somehow this was breaking the seeding of thread-local engines on gcc.
we'll have to investigate this further, but for now i'm reverting this
piece to get messengers working again
Fixes: http://tracker.ceph.com/issues/23778