Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/OSDMap: ignore PGs from pools of failure-domain OSD #20703

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
3 participants
@xiexingguo
Copy link
Member

commented Mar 5, 2018

For testing purpose, we may create pools of failure-domain OSD.
In this case get_parent_of_type() will always return 0 and all
parents of these PGs' up set are considered as collided, and
hence the relevant pg_upmap/items are incorrectly removed during
the maybe_remove_pg_upmaps() procedure.

Fix the above problem by skipping these PGs and also try to be
more specific if we are unable to load the parent of a specified
PG.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

osd/OSDMap: ignore PGs from pools of failure-domain OSD
For testing purpose, we may create pools of failure-domain OSD.
In this case get_parent_of_type() will always return 0 and all
parents of these PGs' *up set* are considered as collided, and
hence the relevant pg_upmap/items are incorrectly removed during
the maybe_remove_pg_upmaps() procedure.

Fix the above problem by skipping these PGs and also try to be
more specific if we are unable to load the parent of a specified
PG.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@xiexingguo xiexingguo requested a review from liewegas Mar 5, 2018

@liewegas
Copy link
Member

left a comment

I think we could also make get_immediate_parent_of take a leaf/osd instead of only a bucket id

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

http://pulpito.ceph.com/kchai-2018-03-08_12:59:37-rados-wip-kefu-testing-2018-03-08-1932-distro-basic-smithi/

  • the swift failure was caused by #20419
  • and i reran osd-pool-create.sh multiple times locally, and was not able to reproduce that failure.

@tchaikov tchaikov merged commit a6c271e into ceph:master Mar 8, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-balancer-01 branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.