osd/OSDMap: ignore PGs from pools of failure-domain OSD #20703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For testing purpose, we may create pools of failure-domain OSD. In this case get_parent_of_type() will always return 0 and all parents of these PGs' *up set* are considered as collided, and hence the relevant pg_upmap/items are incorrectly removed during the maybe_remove_pg_upmaps() procedure. Fix the above problem by skipping these PGs and also try to be more specific if we are unable to load the parent of a specified PG. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
approved these changes
Mar 5, 2018
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing purpose, we may create pools of failure-domain OSD.
In this case get_parent_of_type() will always return 0 and all
parents of these PGs' up set are considered as collided, and
hence the relevant pg_upmap/items are incorrectly removed during
the maybe_remove_pg_upmaps() procedure.
Fix the above problem by skipping these PGs and also try to be
more specific if we are unable to load the parent of a specified
PG.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn