mgr/dashboard: Add toBytes() method to FormatterService #20978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
changed the title
tspmelo
reviewed
Mar 20, 2018
| const m = RegExp('^(\\d+)\\s*(B|K(B|iB)?|M(B|iB)?|G(B|iB)?|T(B|iB)?|P(B|iB)?|' + | ||
| 'E(B|iB)?|Z(B|iB)?|Y(B|iB)?)?$', 'i').exec(value); | ||
| if (m === null) { | ||
| return false; |
There was a problem hiding this comment.
How will this be used? Would it make more sense to return null?
Could you give an example?
Signed-off-by: Volker Theile <vtheile@suse.com>
votdev
force-pushed
the
improve_formatter
branch
from
cb33c2b
to
e71a33e
Compare
|
@tspmelo Your comment has been implemented. |
|
After this PR is merged, I'll adapt #20972 accordingly. |
|
jenkins retest this please |
1 similar comment
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volker Theile vtheile@suse.com