cmake: bump target jdk to 1.7 #21082
Conversation
|
@wido could you help take a look -- does this change look sane? |
|
@tchaikov Yes, I think it is. However, 1.6 still seems low to me. Java 7 (1.7) is already EOL and Java 8 might go soon as well. I'd even say that we bump it to 1.8, but yes, 1.6 is better then 1.5 |
|
Actually I prefer dropping such options, and use the default values. For example, people use jar built for centos 7 only on centos 7 by installing official rpms. However I'm not familiar with java ecosystem, not sure how people use these jars. |
|
BTW, what's javac version ceph going to support? If the minimal requirement for javac is 9, we can use |
|
just checked openjdk on centos 7, it's still 1.8.. |
|
@zhsj Ubuntu 16.04 is also on Java 8, so we should probably go there. Could you maybe bump it do 1.8? |
|
@wido probably no. I just checked https://download.ceph.com/debian-luminous/dists/ still has jessie, precise, trusty. precise only has java 6, trusty and jessie have java 7. I don't know if the supported distribution will be changed during minic. |
|
Oh, https://download.ceph.com/debian-luminous/pool/main/c/ceph/ doesn't have precise. Maybe we can bump to 1.7? centos 6 seems having openjdk 1.8 too. |
jdk 1.7 was released on 2011. For CentOS 6/7, both have openjdk 1.8. For Debian 8(jessie), Ubuntu 14.04(trusty) have openjdk 1.7. These are the oldest distributions officially built for during luminous release. Since jdk 1.9/9, the minimal supported version is 1.6/6. jdk 1.0/10(recently released) only supports 1.7/7. http://openjdk.java.net/jeps/182 Fixes: http://tracker.ceph.com/issues/23458 Signed-off-by: Shengjing Zhu <zhsj@umcloud.com>
|
I bumped it to 1.7 and adjusted the commit message. |
|
1.7 seems good to me. Later we can bump even further. |
It's been 10+ years since jdk 1.6 first released. I think it's
safe now to bump the target to 1.6.
Since jdk 1.9/9, the minimal supported version is 1.6/6.
jdk 1.0/10(recently released) only supports 1.7/7.
http://openjdk.java.net/jeps/182
Fixes: http://tracker.ceph.com/issues/23458