luminous: common: fix BoundedKeyCounter const_pointer_iterator #21083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with libc++, clang fails to compile a call to: vector::assign(const_pointer_iterator, const_pointer_iterator) because const_pointer_iterator does not satisfy the InputIterator concept. added the necessary typedefs for value_type and reference to reflect the pointer type Fixes: http://tracker.ceph.com/issues/22139 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit fa034b6)
|
retest this please |
|
@cbodley Does this need both rgw and rados suites, or is just rgw sufficient? |
|
@smithfarm rgw is plenty, thanks. this one just fixed a compile error with clang |
cbodley
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/23227