Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Add Api module #21126

Merged
merged 2 commits into from Apr 10, 2018
Merged

mgr/dashboard: Add Api module #21126

merged 2 commits into from Apr 10, 2018

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Mar 29, 2018

Moved all the api related services into the new module.

mgr/dashboard: Move services provision to service module
Few services were being declared in the shared module.

@LenzGr
Copy link
Contributor

LenzGr commented Apr 6, 2018

@tspmelo please rebase your changes

@tspmelo
Copy link
Contributor Author

tspmelo commented Apr 6, 2018

@LenzGr done.

@tspmelo
Copy link
Contributor Author

tspmelo commented Apr 6, 2018

jenkins retest this please

Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Tiago Melo added 2 commits April 9, 2018 16:52
Moved all the api related services into the new module.

Signed-off-by: Tiago Melo <tmelo@suse.com>
Few services were being declared in the shared module.

Signed-off-by: Tiago Melo <tmelo@suse.com>
@tspmelo
Copy link
Contributor Author

tspmelo commented Apr 10, 2018

jenkins retest this please

@LenzGr LenzGr merged commit 116aa62 into ceph:master Apr 10, 2018
@tspmelo tspmelo deleted the wip-services branch April 10, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants