luminous: src: s/--use-wheel// #21177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--use-wheel was deprecated in favor of --only-binary in pip v7.0.0. and --use-wheel was removed in a recent release of pip. but some packages are source packages, so we cannot simply replace use-wheel with only-binary. so a simpler approach is to drop --use-wheel option, as pip respects --find-links, and will find the required package from the wheelhouse. Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit a80cce4) Conflicts: src/ceph-detect-init/CMakeLists.txt src/ceph-disk/CMakeLists.txt: trivial resolution src/pybind/mgr/dashboard/CMakeLists.txt: dashboard2 is not in luminous, so drop this change.
smithfarm
approved these changes
Apr 2, 2018
|
This backport didn't include the fixes for the file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--use-wheel was deprecated in favor of --only-binary in pip v7.0.0. and
--use-wheel was removed in a recent release of pip. but some packages
are source packages, so we cannot simply replace use-wheel with
only-binary. so a simpler approach is to drop --use-wheel option, as pip
respects --find-links, and will find the required package from the
wheelhouse.
Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit a80cce4)
Conflicts:
src/ceph-detect-init/CMakeLists.txt
src/ceph-disk/CMakeLists.txt: trivial resolution
src/pybind/mgr/dashboard/CMakeLists.txt: dashboard2 is not
in luminous, so drop this change.