-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd: python bindings fixes and improvements #21304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@rjfd Can you do me a favor and create a tracker ticket so that this can be backported to luminous? |
@dillaman sure. Do you want separate tickets for each one of the commits? |
@rjfd nah -- just one ticket for this entire PR is ok. |
Fixes: http://tracker.ceph.com/issues/23609 Signed-off-by: Ricardo Dias <rdias@suse.com>
Fixes: http://tracker.ceph.com/issues/23609 Signed-off-by: Ricardo Dias <rdias@suse.com>
Fixes: http://tracker.ceph.com/issues/23609 Signed-off-by: Ricardo Dias <rdias@suse.com>
190a884
to
08cee16
Compare
@dillaman http://tracker.ceph.com/issues/23609 Updated commit messages with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR includes:
The above changes were made while implementing the "rbd management" functionality for the ceph dashboard https://github.com/rjfd/ceph/tree/wip-dashboard-rbd