Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: python bindings fixes and improvements #21304

Merged
merged 3 commits into from
Apr 10, 2018

Conversation

rjfd
Copy link
Contributor

@rjfd rjfd commented Apr 9, 2018

This PR includes:

  • Some python 3 fixes regarding the handling of strings for the data_pool
  • Adds a new API function to retrieve the data_pool id
  • Forces the returned timestamps to be in UTC

The above changes were made while implementing the "rbd management" functionality for the ceph dashboard https://github.com/rjfd/ceph/tree/wip-dashboard-rbd

@rjfd rjfd requested review from trociny and dillaman April 9, 2018 13:33
@rjfd rjfd changed the title rbd: python bindings fixes rbd: python bindings fixes and improvements Apr 9, 2018
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dillaman
Copy link

dillaman commented Apr 9, 2018

@rjfd Can you do me a favor and create a tracker ticket so that this can be backported to luminous?

@rjfd
Copy link
Contributor Author

rjfd commented Apr 9, 2018

@dillaman sure. Do you want separate tickets for each one of the commits?

@dillaman
Copy link

dillaman commented Apr 9, 2018

@rjfd nah -- just one ticket for this entire PR is ok.

@rjfd
Copy link
Contributor Author

rjfd commented Apr 9, 2018

@dillaman http://tracker.ceph.com/issues/23609

Updated commit messages with Fixes: ...

Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trociny trociny merged commit 21e2603 into ceph:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants