mgr/dashboard: Add RGW user and bucket management features #21351
Conversation
votdev
commented
Apr 11, 2018
•
votdev
commented
votdev
requested review from
tspmelo,
p-se,
ricardoasmarques,
LenzGr and
Devp00l
votdev
force-pushed
the
dashboard_rgw_management
branch
9 times, most recently
from
d75bc5d
to
47559a7
Compare
votdev
force-pushed
the
dashboard_rgw_management
branch
7 times, most recently
from
b1c2691
to
57ff0d0
Compare
| @@ -53,6 +49,36 @@ def decorate(cls): | |||
| return decorate | |||
|
|
|||
|
|
|||
| def DetailErrorResponse(func, default_status=500): | |||
| """ | |||
| This decorator ensures that all exceptions are catched and a | |||
votdev
force-pushed
the
dashboard_rgw_management
branch
4 times, most recently
from
b7b9ad3
to
6e26b33
Compare
votdev
force-pushed
the
dashboard_rgw_management
branch
3 times, most recently
from
093ff2c
to
c0913ad
Compare
|
QA tests results: http://pulpito.ceph.com/rdias-2018-04-26_15:40:43-rados:mgr-wip-rdias-testing-distro-basic-smithi/ There is one failure but I think it's unrelated with this PR. |
|
jenkins retest this please |
|
QA tests all successful: http://pulpito.ceph.com/rdias-2018-04-27_08:08:19-rados:mgr-wip-rdias-testing-distro-basic-mira/ |
|
minor: What about being more verbose when we don't have subusers, capabilities, etc... Something like
Instead of
|
|
minor: On RBD form, we decided to disable the submission on "Enter key pressed". If we want consistency, we should disable it here too. |
|
minor: Shouldn't we use a IMO, the
|
| @Directive({ | ||
| selector: '[cdCopy2ClipboardButton]' | ||
| }) | ||
| export class Copy2ClipboardButtonDirective implements OnInit { |
There was a problem hiding this comment.
Adding a reusable component on shared module deserves a separate commit.
This helps the review, and also future maintenance.
(something to take into account in the future...)
votdev
force-pushed
the
dashboard_rgw_management
branch
from
c0913ad
to
1e666f2
Compare
|
@ricardoasmarques Your comments has been addressed. |
|
@rjfd I'm now catching exceptions more selective. |
votdev
force-pushed
the
dashboard_rgw_management
branch
4 times, most recently
from
29805d7
to
f577ded
Compare
|
@ricardoasmarques A separate commit has been created for the Copy2ClipboardButtonDirective. |
Signed-off-by: Volker Theile <vtheile@suse.com>
Signed-off-by: Volker Theile <vtheile@suse.com>
Signed-off-by: Volker Theile <vtheile@suse.com>
- Do some minor improvements in the RGW client - Do not catch ALL exceptions to do not block the current exception handler that prints the stack trace in the log file - Throw RequestException istead of Exception when user does not have the required keys Signed-off-by: Volker Theile <vtheile@suse.com>
votdev
force-pushed
the
dashboard_rgw_management
branch
from
f577ded
to
87ff98c
Compare
|
retest this please |
