[DNM] Improve rgw management #21692
Closed
[DNM] Improve rgw management #21692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volker Theile <vtheile@suse.com>
- Return always a HTTP 500 status code in case of an error - Add meaningful error message to be displayed in the UI Signed-off-by: Volker Theile <vtheile@suse.com>
votdev
force-pushed
the
improve_rgw_management
branch
from
a9a05f6
to
731067b
Compare
|
Closed because PR #21351 must address review comments, so this improvement can be included, too. |
rjfd
reviewed
Apr 27, 2018
| try: | ||
| rgw_client = RgwClient.instance(uid) | ||
| return rgw_client.create_bucket(bucket) | ||
| except Exception as e: # pylint: disable=broad-except |
There was a problem hiding this comment.
The problem here, and also in the RgwProxy controller, is that you are catching ALL errors, and you are skipping our current exception handler that prints the stack trace in the log file.
Can you be a bit more precise/specific on the kind of exceptions you want to catch here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires PR #21351.
Signed-off-by: Volker Theile vtheile@suse.com