osd: fix crash caused by divide by zero in heartbeat code #21373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As nothing prevents osd heartbeat interval from being 0 or less, it's possible to crash single OSD/entire cluster using rogue injectargs. It can crash if it's set to anything above 86400, too. This fixes the code so it doesn't crash anymore. Signed-off-by: Piotr Dałek <piotr.dalek@corp.ovh.com>
Previously this var was unbounded, meaning that rogue injectargs could kill the cluster. Also, add a description to it and to osd_heartbeat_min_size. Signed-off-by: Piotr Dałek <piotr.dalek@corp.ovh.com>
tchaikov
reviewed
Apr 12, 2018
| @@ -2862,7 +2862,8 @@ std::vector<Option> get_global_options() { | |||
|
|
|||
| Option("osd_heartbeat_interval", Option::TYPE_INT, Option::LEVEL_ADVANCED) | |||
| .set_default(6) | |||
| .set_description(""), | |||
| .set_min_max(1, 86400) | |||
tchaikov
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the osd_heartbeat_interval is set to 0 or anything above 86400, the osd will crash because of divide by zero in loadavg gathering code. This PR fixes this and adds run-time config boundaries for osd_heartbeat_interval.
Signed-off-by: Piotr Dałek piotr.dalek@corp.ovh.com