Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: disable -Werror when compiling env_librados_test #21433

Merged
merged 1 commit into from Apr 16, 2018

Conversation

tchaikov
Copy link
Contributor

to silence warnings like

utilities/env_librados.cc:175:33: warning: unused parameter ‘offset’ [-Wunused-parameter]
Status InvalidateCache(size_t offset, size_t length) {
^~~~~~

Signed-off-by: Kefu Chai kchai@redhat.com

to silence warnings like

utilities/env_librados.cc:175:33: warning: unused parameter ‘offset’ [-Wunused-parameter]
   Status InvalidateCache(size_t offset, size_t length) {
                                 ^~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov requested a review from jdurgin April 15, 2018 14:42
@tchaikov
Copy link
Contributor Author

@tchaikov
Copy link
Contributor Author

tchaikov commented Apr 15, 2018

Copy link
Member

@liewegas liewegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay. We could also do (void)paramname; statements to explicitly ignore args, right?

@tchaikov
Copy link
Contributor Author

yeah, that's another option.

@tchaikov tchaikov merged commit 073f6f6 into ceph:master Apr 16, 2018
@tchaikov tchaikov deleted the wip-qa-env_librados_test branch April 16, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants