mon/OSDMonitor: txsize should be greater or eq to prune_interval - 1 #21430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this change addresses error messages like setting combinations like should work instead of triggering the errors above. |
jecluis
approved these changes
Apr 14, 2018
tchaikov
commented
Apr 14, 2018
src/mon/OSDMonitor.cc
Outdated
| derr << __func__ | ||
| << "'mon_osdmap_full_prune_txsize' (" << txsize | ||
| << ") <= 'mon_osdmap_full_prune_interval' (" << prune_interval | ||
| << ") <= 'mon_osdmap_full_prune_interval-1' (" << prune_interval - 1 |
so we can prune 1 or more intervals in a single iteration. and in each interval, we prune (prune_interval - 1) versions of osdmap. Signed-off-by: Kefu Chai <kchai@redhat.com>
|
changelog
|
tchaikov
force-pushed
the
wip-osdmap-prune
branch
from
9622515
to
f4fabb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we can prune 1 or more intervals in a single iteration. and in each
interval, we prune (prune_interval - 1) versions of osdmap.
Signed-off-by: Kefu Chai kchai@redhat.com