cmake, common: silence cmake and gcc warnings #21484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-cmake-common-cleanup
branch
3 times, most recently
from
7acb257
to
7cefddd
Compare
tchaikov
force-pushed
the
wip-cmake-common-cleanup
branch
2 times, most recently
from
23e4d50
to
76aa00d
Compare
Preforker.h:111:8: warning: ignoring return value of ‘ssize_t
safe_write(int, const void*, size_t)’, declared with attribute
warn_unused_result [-Wunused-result]
(void)safe_write(fd[1], &r, sizeof(r));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
and
compat.cc:36:28: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (off + sizeof(data) > len)
~~~~~~~~~~~~~~~~~~~^~~~~
Fixes: http://tracker.ceph.com/issues/23774
Signed-off-by: Kefu Chai <kchai@redhat.com>
it's intended behavior to use imported or alias target for dependencies with name with "::" in it. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-cmake-common-cleanup
branch
2 times, most recently
from
db3b69f
to
43d251a
Compare
cbodley
approved these changes
Apr 18, 2018
|
@jdurgin can we have this PR in mimic? |
batrick
reviewed
Apr 19, 2018
| @@ -108,7 +108,7 @@ class Preforker { | |||
| int signal_exit(int r) { | |||
| if (forked) { | |||
| /* If we get an error here, it's too late to do anything reasonable about it. */ | |||
| (void)safe_write(fd[1], &r, sizeof(r)); | |||
| [[maybe_unused]] auto n = safe_write(fd[1], &r, sizeof(r)); | |||
the boost's download page offers the SHA256 hash, so it'd be easier to verify the hash this way. Signed-off-by: Kefu Chai <kchai@redhat.com>
to silence the warnings like
CMake Warning at CMakeLists.txt:73 (find_package):
By not providing "Findgflags.cmake" in CMAKE_MODULE_PATH this project
has
asked CMake to find a package configuration file provided by "gflags",
but
CMake did not find one.
Could not find a package configuration file provided by "gflags" with
any
of the following names:
gflagsConfig.cmake
gflags-config.cmake
Add the installation prefix of "gflags" to CMAKE_PREFIX_PATH or set
"gflags_DIR" to a directory containing one of the above files. If
"gflags"
provides a separate development package or SDK, be sure it has been
installed.
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-cmake-common-cleanup
branch
from
43d251a
to
3178bb9
Compare
|
i am dropping the commit bumping boost version to 1.67 out of this PR, so it is safer to be merged into mimic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.