cmake,make-dist: bump up boost version to 1.67 #21572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's separated from #21484 |
cbodley
approved these changes
Apr 20, 2018
tchaikov
force-pushed
the
wip-boost-1.67
branch
from
7eb8968
to
9f94359
Compare
* to pick up the fix of https://svn.boost.org/trac10/ticket/11622 * also the boost::python's library name now includes the version suffix of python version, so update BuildBoost.cmake accordingly. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-boost-1.67
branch
from
9f94359
to
53a1500
Compare
wjwithagen
approved these changes
Apr 22, 2018
cbodley
reviewed
Apr 27, 2018
| @@ -78,7 +78,7 @@ struct bound_completion_handler : public invoker<Result> { | |||
| // static check for CompletionHandler concept (must be CopyConstructible and | |||
| // callable with no arguments) | |||
| using namespace boost::asio; | |||
| BOOST_ASIO_COMPLETION_HANDLER_CHECK(bound_completion_handler, *this) type_check; | |||
| BOOST_ASIO_LEGACY_COMPLETION_HANDLER_CHECK(bound_completion_handler, *this) type_check; | |||
There was a problem hiding this comment.
just leaving a note that this line will go away eventually. it was tagged as 'legacy' because its CopyConstructible requirement was removed. there's work in progress on a generalized async::Completion type in #21271 - once that merges, i plan to use it to replace most of this stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of python version, so update BuildBoost.cmake accordingly.
Signed-off-by: Kefu Chai kchai@redhat.com