Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Add 'autofocus' directive #21559

Merged
merged 2 commits into from
Apr 24, 2018
Merged

mgr/dashboard: Add 'autofocus' directive #21559

merged 2 commits into from
Apr 24, 2018

Conversation

votdev
Copy link
Member

@votdev votdev commented Apr 20, 2018

This directive makes sure that input fields are focused automatically.

Signed-off-by: Volker Theile vtheile@suse.com

@tchaikov
Copy link
Contributor

retest this please.

@tchaikov
Copy link
Contributor

Error: src/app/shared/directives/autofocus.directive.spec.ts(5,23): error TS2554: Expected 1 arguments, but got 0.

Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SharedModule should export AutofocusDirective

@@ -23,7 +24,8 @@ import { ServicesModule } from './services/services.module';
],
declarations: [
PasswordButtonDirective,
DimlessBinaryDirective
DimlessBinaryDirective,
AutofocusDirective
],
exports: [
ComponentsModule,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutofocusDirective should also be added to the exports to guarantee that it can be used by other modules.

Signed-off-by: Volker Theile <vtheile@suse.com>
Signed-off-by: Volker Theile <vtheile@suse.com>
Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LenzGr LenzGr added this to the mimic milestone Apr 24, 2018
@LenzGr LenzGr merged commit b89dbe9 into ceph:master Apr 24, 2018
@votdev votdev deleted the autofocus branch April 24, 2018 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants