mds: include nfiles/nsubdirs of directory inode in MClientCaps #21668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batrick
approved these changes
Apr 26, 2018
batrick
requested changes
Apr 29, 2018
| change_attr(0), | ||
| truncate_seq(0), | ||
| time_warp_seq(0), | ||
| osd_epoch_barrier(oeb), |
There was a problem hiding this comment.
This was accidentally removed. It's initializing osd_epoch_barrier(0) (the default). Causes: http://tracker.ceph.com/issues/23927
ukernel
force-pushed
the
wip-23855
branch
2 times, most recently
from
2b00706
to
cbe1b40
Compare
|
fixed, thanks |
batrick
approved these changes
May 1, 2018
From: /ceph/teuthology-archive/pdonnell-2018-05-01_20:44:02-kcephfs-wip-pdonnell-testing-20180501.191840-testing-basic-smithi/2463226/teuthology.log Because kclient not patched yet? |
|
patch for kclient is buggy |
|
previous patch is buggy, it didn't check if cap message contains valid dirstat |
Directory inode's dirstat gets updated by request reply, but not by cap message. This causes problem for following case. 1. MDS modifies a directory 2. MDS issues CEPH_CAP_ANY_SHARED to client 3. The client satifies stat(2) by its cached metadata. Signed-off-by: "Yan, Zheng" <zyan@redhat.com> Fixes: http://tracker.ceph.com/issues/23855
batrick
approved these changes
May 3, 2018
batrick
added a commit
that referenced
this pull request
May 7, 2018
* refs/pull/21668/head: mds: include nfiles/nsubdirs of directory inode in MClientCaps Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directory inode's dirstat gets updated by request reply, but not by
cap message. This causes problem for following case.
Signed-off-by: "Yan, Zheng" zyan@redhat.com
Fixes: http://tracker.ceph.com/issues/23855