pybind/ceph_daemon: expand the order of magnitude of daemonperf statistics to ZB #21765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
May 2, 2018
src/pybind/ceph_daemon.py
Outdated
| unit = 0 | ||
| while len("%s" % (int(n) // (1000**unit))) > width - 1: | ||
| unit += 1 | ||
| if unit >= len(units) - 1: | ||
| unit = len(units) - 1 | ||
| break |
There was a problem hiding this comment.
i'd suggest apply following patch
diff --git a/src/pybind/ceph_daemon.py b/src/pybind/ceph_daemon.py
index 0ab5911955..79b0889470 100644
--- a/src/pybind/ceph_daemon.py
+++ b/src/pybind/ceph_daemon.py
@@ -184,9 +184,11 @@ class DaemonWatcher(object):
Format a number without units, so as to fit into `width` characters, substituting
an appropriate unit suffix.
"""
- units = [' ', 'k', 'M', 'G', 'T', 'P']
+ units = [' ', 'k', 'M', 'G', 'T', 'P', 'E', 'Z']
unit = 0
while len("%s" % (int(n) // (1000**unit))) > width - 1:
+ if unit >= len(units) - 1:
+ break
unit += 1
if unit > 0:
|
instead of putting the bug report as the title of the commit message, could you summarize your change in the title? |
tchaikov
reviewed
May 2, 2018
src/pybind/ceph_daemon.py
Outdated
| unit = 0 | ||
| while len("%s" % (int(n) // (1000**unit))) > width - 1: | ||
| if unit >= len(units) -1: |
There was a problem hiding this comment.
please add a space after -.
daemonperf statistics to ZB Fixes: http://tracker.ceph.com/issues/23962 Signed-off-by: Guan yunfei <yunfei.guan@xtaotech.com>
yunfeiguan
changed the title
tchaikov
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/23962
Signed-off-by: Guan yunfei yunfei.guan@xtaotech.com