rgw: require --yes-i-really-mean-it to run radosgw-admin orphans find #22036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrect use of orphans find can lead to data loss. Warn users to be extra cautious. Fixes: http://tracker.ceph.com/issues/24146 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
cbodley
approved these changes
May 16, 2018
theanalyst
reviewed
May 17, 2018
| @@ -6362,6 +6362,13 @@ int main(int argc, const char **argv) | |||
| } | |||
|
|
|||
| if (opt_cmd == OPT_ORPHANS_FIND) { | |||
| if (!yes_i_really_mean_it) { | |||
| cerr << "accidental removal of active objects can not be reversed; " | |||
There was a problem hiding this comment.
We need to mention that this tool just reports the objects, and trusting its output and deleting objects would be irreversible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect use of orphans find can lead to data loss. Warn users to be
extra cautious.
Fixes: http://tracker.ceph.com/issues/24146
Signed-off-by: Matt Benjamin mbenjamin@redhat.com