Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: require --yes-i-really-mean-it to run radosgw-admin orphans find #22036

Merged
merged 1 commit into from May 21, 2018
Merged

rgw: require --yes-i-really-mean-it to run radosgw-admin orphans find #22036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/rgw/rgw_admin.cc
View file
Open in desktop
Expand Up @@ -6362,6 +6362,13 @@ int main(int argc, const char **argv)
}

if (opt_cmd == OPT_ORPHANS_FIND) {
if (!yes_i_really_mean_it) {
cerr << "accidental removal of active objects can not be reversed; "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to mention that this tool just reports the objects, and trusting its output and deleting objects would be irreversible

<< "do you really mean it? (requires --yes-i-really-mean-it)"
<< std::endl;
return EINVAL;
}

RGWOrphanSearch search(store, max_concurrent_ios, orphan_stale_secs);

if (job_id.empty()) {
Expand Down